CockRoachKiller

== ข้อความถูกระงับโดยผู้ดูแล ==
Thank you,

/* NO IF */
 
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <math.h>

float Min(float a,float B )
{
    return(((a+b )-abs(a-B ))/2) ;
}

float Max(float a,float B )
{
    return(((a+b )+abs(a-B ))/2) ;
}

float Min4(float a,float b,float c,float d)
{
    return(Min(Min(a,b ),Min(c,d))) ;
}

float Max4(float a,float b,float c,float d)
{
    return(Max(Max(a,b ),Max(c,d))) ;
}


int main(int argc, char *argv[])
{
    printf("Min=%f Max=%f",Min4(10,11,12,13),Max4(10,11,12,13)) ;
    getch() ;
}
 
 
Your solution is good enough.   I don't see the need in optimizing the number of IF beyond that.  If you really need more speed, just code in assembly and optimize at that level.

 

Go to hell for everyone who names our king into this dispute. Red shirt has gone too far this time. King speech or not is irrelevant. The dam should be built by it's value.

 

ทำเพื่ออะไร คุณก็ลองเดาเจตนาดูเถอะครับ เสื้อแดงดึงกระแสนี้มาเล่น เพียงเพื่อต้องการบลัฟฝ่ายที่คัดค้านการสร้างเขื่อน

ทั้งๆที่ไม่เกี่ยวข้องกันเลย ผมถามว่า เจตนาคืออะไร  ดีครับ คุณช่วยเตือนๆคนเสื้อแดงไว้บ้างก็ดี แล้วลองหักล้างข้อดีข้อเสีย

ในการสร้างเขื่อนดูอีกคำรบ ได้อะไร เสียอะไร 

 

 

I am just one of fifty shade of red.  Not all cockroaches agree on every topic right. 

Go to hell for everyone who names our king into this dispute. Red shirt has gone too far this time. King speech or not is irrelevant. The dam should be built by it's value.

 

ไอ้น้องเฮนไต เอ๊ย ไอ้น้องค็อก ที่ไม่ได้แปลว่าไก่ 

 

คนเขียนบทความนี้รู้ได้อย่างไรรึ ว่าโสเภณีโง่หมายถึงนางยก หุ่นเชิดของไอ้สารเลว

 

ผมนึกว่าผมรู้สึกอยู่คนเดียว

 

 

Yeah, I am also Mr Lee, Mr 100 login or No more.   You guys have serious brain trauma.

 

 

 

Thaksin will be back.  Our country will be right on track again after a decade lost.

ใคร ห้ามให้ เขากลับ ....

ตอนสมัคร สุนทรเวช เป็นนายกรัฐมนตรี    เป็นก็กลับมาสู้คดีเอง

นักโทษชายทักษิณ เป็นคนเดินขึ้นศาลเอง   โดยบอกว่าบ้านเมืองเป็นประชาธิปไตยแล้วพร้อมต่อสู้ตามกระบวนการยุติธรรม

และคดีนี้ก็ตัดสินในช่วงที่พรรคพลังประชาชนของนักโทษชายทักษิณเป็นรัฐบาลมีอำนาจเต็มที่ในฝ่ายบริหาร

คนทั้งประเทศ 15 ล้านตัดสินให้แล้ว ว่า จะเข้าข้าง

 

 

 

มวยขึ้นเวที เขามีกติกา แล้วชกตามกติกา แม้อาจคิดไปว่า กรรมการเข้าข้างอีกฝ่าย ...คนเก่ง ก็ต้องชนะ วันยังค่ำ

คนที่นั้น นั่นคือ เท่ห์ สุดยอด

 

กลับกัน มวยขึ้นเวที เขามีกติกา แล้วไม่ชกตามกติกา โทษ กรรมการเข้าข้างอีกฝ่าย

 

พยามหาทาง ซื้อกรรมการให้เข้าข้าง  จนเลยไป แก้ กติกาว่า ......หากชกแพ้ ให้เสมอ

 

คนแบบนี้ไม่ใช่ เท่ห์ แต่เขาเรียก พวกขี้ขลาด ครับ ...คุณนับถือคนแบบนี้ ...แต่สำหรับผม "คนนี้ น่าสมเพช..

 

 

That's what you think.  You have your right to look at that way.  However, I have my right to comprehend at the same story differently. 

 

''In legal terminology, we call it the fruit of a poisoned tree. The fruit will undoubtedly get poisoned as long as the tree has already been poisoned,''  Thaksin said.

 

The most logical thing to justify this event is by reversing the situation.  If Marc wins the next general election and somehow get kicked out by military coup, of course, from Thaksin side.   Later, the coup also appoints a number of investigating committee to handle Marc and Suthep guild for murdering 99 people or Marc military desertion.  At the end, suppose court said "guilty as charge".   Will Marc ever accept that? 

 

Solving a problem by making an exception just create more complex problems. By accepting military coup, you did make an exception. Yes you did. Why that coup does not get any punishment? Between ripping off the constitution by tank and corruption on buy/sell properties which one look more evil. For me, Thaksin has full right to refuse everything, because you have no right to kick him out in the first place.

 

Are you daring enough for reopening all Thaksin cases after we have a new constitution by real Thai people without military coup shadow? If court still says guilty, I can accept that and will blame him as well.

 

Which one is more pathetic between the guy who was kicked out by force and keep fighting back in every possible way to reclaim his right and the other one who sit comfortably ring side and can simply should "guilty" from time to time.   Which one is coward?

--------------------------------------------------------------------------------------------------------------------------------------------------------

 

 

 

For cockroaches, nothing can change your obsession right? or Of course, Thaksin have bough this author which happens to be a two-term member of Philippine congress.  

I just run your program and it confirms my quick glance speculation.  My Visual Studio detected that problem appear at ch2[] right away while running the program.  Furthermore, I found that you can not use standard strcmp() because you incorrectly declare all your C Strings.

 

These are also wrong beside ch[4] and ch2[4] that I have notified.

 

char four[][4] = {"damn","fuck","mofo","cock","arse"};
char polite[][4] = {"mali","love","like","well","kind"};

 

The problem with that there is not enough space to contain \0.   Unfortunately, your \0 of "damn" will be overridden by "fuck" and so on.   Eventually, in memory four[0] - > "damnfuckmofocockarse" not "damn".  Your version of strcmp work by the fact the you hard code 4 in that function.  Without that hardcode, your code will fail the same way as standard strcmp fail.   Because when you think you are checking any word against "damn" , you actually compare it with "damnfuckmofocockarse" instead. 

 

The correct way is

char *four[] = {"damn","fuck","mofo","cock","arse"};
char *polite[] = {"mali","love","like","well","kind"};

C string is compact and efficient.  However, the schematic is obscured.  Zero byte at the end confuse most beginners.  This is one of the many reasons why C is hated by most programmers.  I never recommend any beginner to start with C. 

 

If you decare it correctly.  The checkAndChange() could be simple as this

 

void checkAndChange(char *word){
    int i; /* control for outer and inner loop */
    for( i = 0; i < 5; ++i){
        if(strcmp(four[i],word)==0){/* change it with polite word */
            strcpy(word,polite[i]);
            break;
        }
    }
}
 

 

If you like to improve it further, here are my advices.

 

1) remove hardcode 5 from the program. 

2) replace concatT with standard strcat()

3) support any size of bad word and case insinsitive

4) read list of bad word from file

5) find a way to make it at least 2 time running

 

 

In case you intend to pursue my advice, this man will make you test your program much quicker.  At the development stage, you should avoid manual input.  When the program is good enough, then you can play with UI later.

 

int main(int argc, char *argv[])
{
    checkFour("yes no ok cocacola damn fuck mofo cock arse cockroachkiller",out);
    printf("%s\n",out);
    return 0;
}
 

 

Have fun..

strcmp never fail.  Your method might.  However, I have to admire you on creating your own version when you found a problem. 

 

With a quick glance, '\n' '\r\ should not be the problem.  Anyway, I think you misunderstand something about C.

 

for char data[4]   you can correctly store only 3 character + one \0 not 4 char.

 

So, code like

char ch[4]; /* temporary char */
char ch2[4]; /* temporary copy of word */

strcpy(ch2,word); /* copy it avoid test for another position */

 

With a "word" size of 4 the strcpy will corrupt your stack.  It might put \0 on ch[0] or somewhere else which will cause trouble later.   No surprise that your strcmp will fail. 

 

Try to change it to [5], should solve the problem.

 

My advice are, 

*if you target is not micro controller,  no need to get cheap on space.   char ch[4] or char ch[1024] make no different in today computer.  They run at should the same speed.

** you should polish your program.   Make it shorter, run faster or easier to read always help you improve your coding.  More unnecessary code, more bugs.

 

The obvious example is that you don't need that  ch and ch2 at all.  You create that unnecessary and that unnecessary bite you.  

 

 

 

 

 

A picture worth a thousand words.

Long live the king.

Congratulation! It might still has a bug, but at least it's not an obvious one.   My suggestion for more extensive testing is

 

- try using the same data file to delete all nodes except some particular node.   For example, if you input "C+++".  You need to load data file and deleteNode one by one except "C++". At the end, if you have only C++ node, then your program work very well.     You might need to try other word to make sure. 

 

- use bigger data file > 1M.  

 

 

I don't know why you interest in tree.  To understand how it works, does not mean we have to write it.  I never ever need to use tree in any implementation.  For speed, "hash" is hard to beat, given enough memory.   For simplicity, "array" almost bug free.  You should notice that most language has build in these two already.   You need to have very large, > 100K items to see any significant different between tree and simple array search.    

 

Try modify you code like this  (only main)
 

 

#include <Windows.h>

#define NUMITEMS 1000
int main(int argc, char *argv[])
{

    struct node *cur_node; /* node to delete */
    char *strArray[NUMITEMS];
    char tmp[1024];
    int i,j;
    long start,end;

    for(i=0;i<NUMITEMS;i++){
        int r = rand();
        sprintf(tmp,"%d",r);
        enter(&root, tmp);
        strArray[i] = saveString(tmp);
    }
    start = GetTickCount();
    srand(1000);
    for(i=0;i<100;i++){
        sprintf(tmp,"%d",strArray[rand()%NUMITEMS]);
        cur_node = findTree(root, tmp);
    }
    printf("Tree find time=%d\n",GetTickCount() - start);
    start = GetTickCount();
    srand(1000);
    for(i=0;i<100;i++){
        sprintf(tmp,"%d",strArray[rand()%NUMITEMS]);
        for(j=0;j<NUMITEMS;j++){
            if(strcmp(strArray[j],tmp)==0){
                break;
            }
        }
    }
    printf("Array find time=%d\n",GetTickCount() - start);
}

 

 

 

 

 

 

The new main will create random string of integer for NUMITEMS, put them in your tree and my array strArray.   Then random search for 100 items by your tree and my array.   You will see no different in the time. You need to change NUMITEMS to 100K in order to see the different.    You can try 1M and if your program crash, you will learn something by finding a way to fix it. 

 

*you need to include Windows.h to use GetTickCount() or find another time function.

** GetTickCount() has resolution of 15ms.  So 0 or 15 is not significant due to measurement error.

*** See how easy we can create stupid array and have the same performance as your sophisticated tree for data < 100K.   The best part is, as computer get faster, this number get bigger also.